-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theory paper code #773
base: master
Are you sure you want to change the base?
Theory paper code #773
Conversation
df9a66c
to
a068be1
Compare
Codecov ReportBase: 75.32% // Head: 75.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 75.32% 75.28% -0.04%
==========================================
Files 59 59
Lines 12555 12588 +33
==========================================
+ Hits 9457 9477 +20
- Misses 3098 3111 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
there is still the runPlotSimiSol.py script if still needed update comments in the beginning |
#sphKernel radius for the com1DFA simulations | ||
sphKernelRadius = 6|5|4|3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be part of the com1DFA_override section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is varied outside and updated in the com1DFACfg file that is then created - but maybe needs to be made clear that this overrides it..
5631ea7
to
1c049fd
Compare
1c049fd
to
e69e80e
Compare
e69e80e
to
73553be
Compare
Code Climate has analyzed commit f00fd6a and detected 10 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 94.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.2%. View more on Code Climate. |
Code to produce the figures from the paper:
runDamBreak.py (in the file choose which ini file you want to use)
runSimiSol.py (in the file choose which ini file you want to use)
runEnergyLineTest.py (in the file choose which ini file you want to use)
runRotationTest.py (in the file choose which ini file you want to use and choose either the avaTripleParabola or avaTripleBowl)
Updated online documentation