Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theory paper code #773

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Theory paper code #773

wants to merge 10 commits into from

Conversation

matthiasto
Copy link
Contributor

@matthiasto matthiasto commented Oct 4, 2022

Code to produce the figures from the paper:
runDamBreak.py (in the file choose which ini file you want to use)
runSimiSol.py (in the file choose which ini file you want to use)
runEnergyLineTest.py (in the file choose which ini file you want to use)
runRotationTest.py (in the file choose which ini file you want to use and choose either the avaTripleParabola or avaTripleBowl)

Updated online documentation

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 75.32% // Head: 75.28% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f00fd6a) compared to base (06135d1).
Patch coverage: 92.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   75.32%   75.28%   -0.04%     
==========================================
  Files          59       59              
  Lines       12555    12588      +33     
==========================================
+ Hits         9457     9477      +20     
- Misses       3098     3111      +13     
Impacted Files Coverage Δ
avaframe/ana3AIMEC/aimecTools.py 81.74% <60.00%> (+0.03%) ⬆️
avaframe/ana1Tests/energyLineTest.py 95.13% <73.68%> (-2.60%) ⬇️
avaframe/out3Plot/outAIMEC.py 84.72% <86.66%> (-0.15%) ⬇️
avaframe/out3Plot/outAna1Plots.py 94.40% <96.22%> (+<0.01%) ⬆️
avaframe/ana1Tests/damBreakTest.py 93.43% <100.00%> (ø)
avaframe/ana1Tests/simiSolTest.py 82.40% <100.00%> (-0.93%) ⬇️
avaframe/ana5Utils/distanceTimeAnalysis.py 83.58% <100.00%> (+0.75%) ⬆️
avaframe/out3Plot/plotUtils.py 94.60% <100.00%> (+0.09%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthiasto matthiasto requested review from awirb and fso42 October 5, 2022 07:00
@awirb
Copy link
Contributor

awirb commented Oct 10, 2022

there is still the runPlotSimiSol.py script if still needed update comments in the beginning

Comment on lines 7 to 9
#sphKernel radius for the com1DFA simulations
sphKernelRadius = 6|5|4|3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be part of the com1DFA_override section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is varied outside and updated in the com1DFACfg file that is then created - but maybe needs to be made clear that this overrides it..

avaframe/runScripts/runAnalyzeSimilaritySol.py Outdated Show resolved Hide resolved
avaframe/runScripts/runDamBreak.py Outdated Show resolved Hide resolved
avaframe/runScripts/runSimilaritySol.py Show resolved Hide resolved
avaframe/out3Plot/outAna1Plots.py Outdated Show resolved Hide resolved
avaframe/out3Plot/outAna1Plots.py Outdated Show resolved Hide resolved
avaframe/runScripts/runEnergyLineTest.py Show resolved Hide resolved
avaframe/runScripts/runRotationTest.py Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Dec 6, 2022

Code Climate has analyzed commit f00fd6a and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 6

The test coverage on the diff in this pull request is 94.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.2%.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants