Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fix npm link of AVA as necessary. #827

Merged

Conversation

jamestalmage
Copy link
Contributor

@jamestalmage jamestalmage commented May 12, 2016

PR #815 introduced a fix for npm link, but it broke NYC coverage.

Instead of always applying the "fix", this wraps it in a conditional, such that the old behavior is returned unless we detect a problematic npm link setup (npm link ava on node 6.0.0-6.?.?).

This wraps the "fix" in a conditional, such that the old behavior is returned unless we detect a problematic `npm link` setup (`npm link ava` on node 6.0.0-6.?.?).
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @ingro, @naptowncode and @jokeyrhyme to be potential reviewers

@sindresorhus
Copy link
Member

I don't think you meant to commit ava-0.14.0.tgz.

@jamestalmage
Copy link
Contributor Author

tarball removed.

@sindresorhus sindresorhus merged commit 4abb351 into avajs:master May 13, 2016
@sindresorhus
Copy link
Member

👍

jamestalmage added a commit to jamestalmage/ava that referenced this pull request May 23, 2016
This mostly reverts avajs#815, and avajs#827. The Node regressions they fixed were resolved in Node 6.2.0. The new behavior is just to print a warning message so people know how to fix it.
jamestalmage added a commit to jamestalmage/ava that referenced this pull request May 23, 2016
This mostly reverts avajs#815, and avajs#827. The Node regressions they fixed were resolved in Node 6.2.0. The new behavior is just to print a warning message so people know how to fix it.
sindresorhus pushed a commit that referenced this pull request May 24, 2016
This mostly reverts #815, and #827. The Node regressions they fixed were resolved in Node 6.2.0. The new behavior is just to print a warning message so people know how to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants