Ensure the assertion message is a string #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check for the presence of the extra argument (which should be the
message
) and verify if it's a string.It will try to lookup variable and its value in the scope, but non-linear flow could break it.
Should we cover this ?
Fixes #167
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
assertion-arguments
rule should validate message argument type