Initial Sharepoint integration #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to samvera#418 for what is being built off of.
masaball
commented
Sep 25, 2024
|
|
||
| Prerequisite: | ||
| * App must be registered in the Entra Admin center to receive client_id, client_secret, and tenant_id. | ||
| * If using .default endpoint as your scope, you must register API permissions for your application. Minimum permissions: |
There was a problem hiding this comment.
May also require Sites.Selected when implementing sites. Will need to test .
masaball
commented
Sep 25, 2024
| base.each do |k,v| | ||
| query += ["#{k}=#{v}"] | ||
| end | ||
| query += ["response_type=code"] |
There was a problem hiding this comment.
Rather than initializing query as an empty array, this could be the initialization value instead of adding it later.
If/when we want to commit this back upstream we will want to add back in the code paths for the access without a user auth flow so leaving the initialization as is, with the expectation of having multiple login options may be preferable. (Access without a user requites the client secret to be sent with the auth request and does not send a response_type param).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work adds basic Sharepoint integration to browse_everything. It uses the "access on behalf of a user" authorization flow to allow a user to authenticate to the Microsoft Graph API and upload files from their personal drive(s).
Future work will be to provide upload support from other Sharepoint sites that the user has access to.