Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass mandatory argument to initgame in tests #41

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

giordano
Copy link
Contributor

PR #38 added a new mandatory argument to initgame, which however isn't used in
tests.

@aviks
Copy link
Owner

aviks commented Jul 24, 2021

There is a default to that argument, so this should not be required?

Separately, I havent figured out a way to run the game loop in a headless system, so we don't have CI.

@giordano
Copy link
Contributor Author

There is a default to that argument

Uhm, no:

function initgame(jlf::String, external::Bool)

rungame has a default value for external:

function rungame(jlf::String, external::Bool=true)

Maybe a better solution is to give a default value of external (true?) to initgame as well?

@aviks
Copy link
Owner

aviks commented Jul 24, 2021

Ah, OK, indeed. Actually, this is correct, initgame should not have a default, IMO. I'll add some comments to remind myself what is happening.

@aviks aviks merged commit 6bf9938 into aviks:master Jul 24, 2021
@giordano giordano deleted the mg/tests branch July 24, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants