Remove pinning of unreleased Avocado #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functionality (like the test .data support) was needed on autils but not (then) yet available on a released Avocado version. Now with 102.0 out, it's possible to use it without special gimmicks. Signed-off-by: Cleber Rosa <[email protected]>
richtja
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Hi @clebergnu, thank you for this update, I have just one proposal related to the avocado version.
| @@ -12,7 +12,7 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| - name: Install Avocado to run tests | |||
| run: pip3 install git+https://github.com/avocado-framework/avocado@7998c0a6d1bdd8ce60235cd4d2aa04afbebfe00e#egg=avocado_framework | |||
| run: pip3 install avocado-framework==102.0 | |||
There was a problem hiding this comment.
Base on the BP005 “there shouldn't be any type of release version sync between Avocado and autils”. Therefore, we shouldn't stick to a specific avocado version. What about to add only pip3 install avocado-framework?
richtja
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functionality (like the test .data support) was needed on autils but not (then) yet available on a released Avocado version.
Now with 102.0 out, it's possible to use it without special gimmicks.