Style check based on black #3827
Conversation
clebergnu
force-pushed
the
style_black
branch
4 times, most recently
from
a6bdffd
to
a9fffa5
Compare
There was a problem hiding this comment.
Hi @clebergnu it LGTM, but I was able to review only the black enablement related changes, not the style changes itself (I presume they were made by black). Because of this, I think it is necessary to test these changes with some real avocado-vt test suite. @luckyh can you or any of avocado-vt maintainers test this with some bigger avocado-vt test suite?
|
@YongxueHong @vivianQizhu @chloerh @dzhengfy @chunfuwen adding you to this thread as well for your awareness, thanks. |
|
@yanan-fu would you mind to help trigger a big test loop to verify this? thanks in advance! |
|
@yanan-fu did you get a chance to test this? Thanks in advance! |
clebergnu
force-pushed
the
style_black
branch
from
a9fffa5
to
816dda3
Compare
Hi @clebergnu , sorry for the late response (just came back from leave). Apart from needing to resolve the conflicts it LGTM. Thanks! |
Hi @clebergnu , sorry for the late reply as Holiday and PTOs, as patch conflict, it can not be applied successfully. |
Hi @yanan-fu, Conflicts have been resolved with a rebase. Please note that new conflicts will most certainly appear as other PRs are merged. Thanks. |
@clebergnu Regression test in on going, result will be commented soon. |
|
Regression test all PASS. LGTM, I think it is time to resolve the conflict and merge it now. Thanks all! |
Avocado has been using black to enforce a code style for a long time now, with very good results. Let's expand the same to Avocado-VT. With a common code style across Avocado and Avocado-VT it'll be easier to move libraries to the common autils repo. Reference: avocado-framework/autils#3 Signed-off-by: Cleber Rosa <[email protected]>
Thanks @yanan-fu. I'm considering your ACK on the regression testing a second positive review, and will expedite the merge of these changes to avoid further conflicts (once CI checks pass). |
Avocado has been using black to enforce a code style for a long time now, with very good results. Let's expand the same to Avocado-VT. With a common code style across Avocado and Avocado-VT it'll be easier to move libraries to the common autils repo.
Reference: avocado-framework/autils#3