Update cpu_model_flags value

[leidwang]

Currently, cpu_model_flags's value is missing ',', it may cause
the issue that cpu_model_flags's can be parsed correctly.

ID: 2819

[leidwang]

Hi @YongxueHong
Would you please help review it when you have time?Thanks!

[YongxueHong]

Hi @XueqiangWei , @peixiu , @fbq815 , @lkotek , @yanan-fu
Could you help to review it? Thanks in advance.

[YongxueHong]

LGTM

[fbq815]

seems the change won't influence s390x, could skip this time

[lkotek]

LGTM 👍 I am fine with the change, thanks!

[yanan-fu]

Approve after check the whole logic.

To be safe for all, every += for cpu_model_flags can (need) start with , based on the cpu flag parse rule[1] and the rule of adding cpu flag in command line [2][3].

[1]

avocado-vt/virttest/cpu.py

Line 1457 in f0424ee

flags_list = cpu_flags_str.lstrip(",").split(",")

[2]

avocado-vt/virttest/env_process.py

Line 1431 in f0424ee

params["cpu_model_flags"] = cpu.recombine_qemu_cpu_flags(

[3]

avocado-vt/virttest/qemu_vm.py

Line 1470 in f0424ee

if not flags.startswith(","):

[peixiu]

(11/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_time.q35: STARTED
(11/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_time.q35: PASS (502.87 s)
(12/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_crash.q35: STARTED
(12/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_crash.q35: PASS (366.60 s)
(13/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_reset.q35: STARTED
(13/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_reset.q35: PASS (197.27 s)
(14/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_tlbflush.q35: STARTED
(14/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_tlbflush.q35: PASS (906.57 s)

LGTM!
Acked-by: Peixiu Hou [email protected]

[YongxueHong]

Hi @XueqiangWei
Could you help to review it? Just a kindly reminder.
Thanks in advance.

[XueqiangWei]

LGTM,
Acked-by: [email protected]