Add util module #43
Merged
Add util module #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These functions would be very useful to have. |
|
The functions look good to me, but why put them in a |
|
I put it in a separate module and included it inside |
|
Let's leave the Util module there, since there's a name clash with the |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Aug 4, 2021
CHANGES: * Support Yaml 1.2, and stop advertising Yaml 1.0 support. This also updates the vendored libyaml to 0.2.5 (@favonia avsm/ocaml-yaml#37). * Add a `Yaml.Util` module with a number of useful combinators to manipulate `Yaml.value` types, such as retrieving keys and values, finding entries and converting to OCaml native types (@patricoferris avsm/ocaml-yaml#43) * Move the sexpression derivers into a separate `Yaml_sexp` package (the `yaml-sexp` opam package). This reduces dependencies on the main library. You can still use `Yaml` types in `ppx_sexplib_conv` derivers by simply replacing the `Yaml.value` (or other type) with `Yaml_sexp.value` which is an alias that also includes the Sexp conversion functions in its scope. (@alan-j-hu @avsm avsm/ocaml-yaml#46). * When outputting values, wrap special values like "true" or "1.0" in double quotes, so that `Yaml.of_string` will not interpret them as a non-string value (@avsm avsm/ocaml-yaml#47). * Track anchors and mappings in `Yaml.yaml` (but not in the `Yaml.value` JSON representation). This also allows non-scalar values to be used as keys. (@favonia avsm/ocaml-yaml#38) * Bump the internal write buffer for stream emission to 256k from 64k, as people are writing ever-larger Yaml files! In the future, this static buffer will be replaced by a dynamically growing output buffer but for now needs to be set manually. * The minimum supported OCaml version is now OCaml 4.05.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Yaml.Utilmodule providing some common functions for manipulatingYaml.valuevalues or building simple yaml values from OCaml primitives. It mostly follows the naming convention of havingfandf_exnthe former using the result type and the latter raising an exception. This fixes #40.