Implement cloneWorksheet function to duplicate existing sheets in the workbook #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y will fail with a corresponding warning
…ing worksheet and add it as a new worksheet to the workbook. Content, styles, etc. are properly copied. Missing: Tables (and probably drawings, comments, etc.)
… generate new IDs and new names => cannot just copy over the tables and tableParts lists)
…nting to data in the same sheet to point to the new sheet
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 60.23% 59.35% -0.88%
==========================================
Files 30 30
Lines 7142 7108 -34
==========================================
- Hits 4302 4219 -83
- Misses 2840 2889 +49
Continue to review full report at Codecov.
|
|
Hi, I added your PR into my fork ycphs/openxlsx. I am looking forward to get your support for publishing an updated version of the package on cran. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a cloneWorksheet function to create a full copy of an existing worksheet and add it as a new worksheet to the workbook.
This pull request is my current status, which I'm using myself regularly.
What is working:
What is missing:
For these, I suppose some XML strings stored in the fields of the Workbook class need to be duplicated + modified and new IDs assigned I don't have the insight into the full xlsx file format, so I have not yet figured out which parts need to be duplicated and where an ID needs to be changed. For the styles I think I got it right (at least it seems to be working)
This pull request is intended to fix/implement issues #255 and #330.
This replaces PR #355