Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync forced CRAN changes #488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavisVaughan
Copy link

In hopes to get this un-ORPHANED, I've synced with CRAN's version, 4.1.0.1, and the only difference that I could find was this change regarding the size of the char array.

@awalker89 if you happen to have the old email of the original requests made by CRAN, I'd be interested to take a look and see if anything else is required.

I realize that the version you submitted to CRAN was 4.1.0, and the last commit before you sent to CRAN seems to be this one: 7f96f21

Then CRAN bumped that version to 4.1.0.1.

In the meantime, you bumped your github version to 4.1.1 and added more commits, which is what I worked off of. I think that it would be fine to just add this PR on top of the current master branch, and then send that to CRAN to get this un-ORPHANED.

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #488 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   60.23%   60.07%   -0.17%     
==========================================
  Files          30       30              
  Lines        7142     7023     -119     
==========================================
- Hits         4302     4219      -83     
+ Misses       2840     2804      -36
Impacted Files Coverage Δ
src/read_workbook.cpp 90.55% <ø> (-0.39%) ⬇️
src/write_data.cpp 60.76% <0%> (-3.8%) ⬇️
src/write_file_2.cpp 0% <0%> (-1.43%) ⬇️
R/HyperlinkClass.R 93.02% <0%> (-0.98%) ⬇️
R/workbook_write_data.R 82.35% <0%> (-0.85%) ⬇️
R/writeDataTable.R 71.59% <0%> (-0.32%) ⬇️
R/helperFunctions.R 75.31% <0%> (-0.25%) ⬇️
src/write_file.cpp 88.48% <0%> (-0.17%) ⬇️
R/workbook_read_workbook.R 89.14% <0%> (-0.13%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead0038...857e93a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant