Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortBy Navigation Feature #39

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

sitenzo
Copy link
Contributor

@sitenzo sitenzo commented Nov 28, 2023

Summary

This pull request introduces a new sorting feature in the Filament Quick Create package. The update allows sorting of items by their Resource navigation sort order using ->sortBy('navigation'). This enhancement improves consistency and user experience by aligning items according to the Filament Resource navigation order.

Key Changes

  • SortBy Navigation Implementation: Integrated the ->sortBy('navigation') method, enabling resources to be sorted based on their defined navigation sort order in the Filament admin panel.
  • Code Refinement: Ensured compatibility with existing functionalities and conducted comprehensive testing for stability and performance.
  • Documentation Update: Revised the README and other relevant documentation to include guidance and examples for the new sorting feature.

Impact

  • Enhanced User Experience: Facilitates a more intuitive and streamlined user interface by displaying resources in an order that reflects their setup in the Filament admin panel.

Additional Notes

  • Open to feedback and suggestions for further enhancements or improvements.

@sitenzo sitenzo changed the title Sitenzo add sortBy navigation Add sortBy navigation Nov 28, 2023
@sitenzo sitenzo changed the title Add sortBy navigation Add sortBy Navigation Feature Nov 28, 2023
Copy link
Owner

@awcodes awcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missing the $sortBy property on the class. It will throw an error if ->sortBy() isn't used when registering the plugin.

protected string | Closure $sortBy = 'label';

src/QuickCreatePlugin.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sitenzo sitenzo requested a review from awcodes November 30, 2023 20:45
@sitenzo
Copy link
Contributor Author

sitenzo commented Nov 30, 2023

Hi @awcodes,
Thanks for the feedback.

@awcodes awcodes merged commit 954eccf into awcodes:3.x Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants