Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discount Coupon's activate/deactivate setting in the screen don't work #8908

Closed
soyket opened this issue Oct 1, 2021 · 3 comments · Fixed by #8909
Closed

Discount Coupon's activate/deactivate setting in the screen don't work #8908

soyket opened this issue Oct 1, 2021 · 3 comments · Fixed by #8909
Assignees
@cklosowski
Labels
type-bug
Milestone
2.11.3

Comments

@soyket
Copy link

soyket commented Oct 1, 2021

Bug Report

Expected behavior

When you go to EDD > Discount Codes > Hover over a Discount code > Click Activate / Deactivate to change the status, it should update the status but it doesn't.

The status is only updated when I enter the discount code's edit screen fully and edit it there.

I am on the latest version of the plugin btw.
@cklosowski
Copy link
Contributor

Interestingly enough, the 'quick actions' show us the Activate link, meaning that I think we're caught up in an object level caching issue here.

@cklosowski
Copy link
Contributor

Found the issue, the update_status method was only updating the post_status and not also updating the status meta value.

cklosowski added a commit that referenced this issue Oct 1, 2021
@cklosowski
Update the post meta as well #8908
7d2446a
cklosowski added a commit that referenced this issue Oct 1, 2021
@cklosowski
Adjust to also update the meta #8908
4f4ef09
This was referenced Oct 1, 2021
Merged
Closed
@cklosowski cklosowski self-assigned this Oct 1, 2021
@cklosowski cklosowski added this to the 2.11.3 milestone Oct 1, 2021
@cklosowski cklosowski linked a pull request Oct 1, 2021 that will close this issue
Update post meta 'status' as well as post_status #8909
Merged
@soyket
Copy link
Author

soyket commented Oct 2, 2021

Nice. @cklosowski :) glad you found and resolved it soon

@ashleyfae ashleyfae mentioned this issue Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cklosowski cklosowski

Labels
type-bug
Projects
None yet
Milestone
2.11.3
Development

Successfully merging a pull request may close this issue.

Update post meta 'status' as well as post_status awesomemotive/easy-digital-downloads
3 participants
@cklosowski @ashleyfae @soyket