Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more helper methods to Pass_Manager class #8952

Closed
ashleyfae opened this issue Oct 29, 2021 · 1 comment · Fixed by #8953
Closed

Add more helper methods to Pass_Manager class #8952

ashleyfae opened this issue Oct 29, 2021 · 1 comment · Fixed by #8953
Assignees
Milestone

Comments

@ashleyfae
Copy link
Contributor

ashleyfae commented Oct 29, 2021

Enhancement Request

Explain your enhancement (please be detailed)

We could add some new helper methods that look for specific passes then call pass_compare() for us. Just to reduce repetition in the comparisons we're making.

For example:

  • hasPersonalPass()
  • hasExtendedPass()
  • etc. for each pass type

I would use these in #8941

@robincornett I'm thinking this might be useful for some stuff you're working on too? Anything specific you want to see?

@robincornett
Copy link
Contributor

I would like to have the license key stored with the pass data--I will need that eventually, but I can add it in my own PR that I'll need it for.

ashleyfae added a commit that referenced this issue Oct 29, 2021
Add more helper methods to Pass_Manager class #8952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants