We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I call Pass_Manager::hasPersonalPass() on a site that has no passes, I expect it to return false.
Pass_Manager::hasPersonalPass()
The following exception is thrown:
InvalidArgumentException: Invalid pass 1:
The same is true for all other pass methods introduced in #8953
It just calls:
return self::pass_compare( $this->highest_pass_id, self::PERSONAL_PASS_ID, '=' );
But when $this->highest_pass_id is null, it doesn't work. We should be checking that before running the comparison.
$this->highest_pass_id
PHP Version:
EDD Version (or branch): release/2.11.4
WordPress Version:
Any other relevant information:
The text was updated successfully, but these errors were encountered:
Catch exceptions and return false #8965
d96eeab
Fix typo in variable name. #8965
b0fe017
Reset licensed products global before each test #8965
5ea4f9e
Merge pull request #8966 from awesomemotive/issue/8965
4895669
ashleyfae
Successfully merging a pull request may close this issue.
Bug Report
Expected behavior
When I call
Pass_Manager::hasPersonalPass()
on a site that has no passes, I expect it to return false.Actual behavior
The following exception is thrown:
The same is true for all other pass methods introduced in #8953
It just calls:
But when
$this->highest_pass_id
is null, it doesn't work. We should be checking that before running the comparison.Steps to reproduce the behavior
Information (if a specific version is affected):
PHP Version:
EDD Version (or branch): release/2.11.4
WordPress Version:
Any other relevant information:
The text was updated successfully, but these errors were encountered: