Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require the purchase button to have a specific ID attribute #8834 #8850

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

cklosowski
Copy link
Contributor

Fixes #8834

Proposed Changes:

  1. Removes the assignment of the purchase button to a variable based on the ID
  2. Uses the instance of $(this) to address the purchase button

@cklosowski
Copy link
Contributor Author

Steps to replicate are here: #8834 (comment)

Copy link
Contributor

@robincornett robincornett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working, but noting that PayPal Commerce Pro removes all of the checkout button filters with:

remove_all_filters( 'edd_checkout_button_purchase' );

so the sample code in the issue does not work for PayPal Commerce Pro.

@ashleyfae ashleyfae merged commit f4dd724 into release/2.11.2 Sep 8, 2021
@ashleyfae ashleyfae deleted the issue/8834 branch September 8, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom checkout button markup can cause a JS error when clicked.
3 participants