Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue instead of return #8867 #8868

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Continue instead of return #8867 #8868

merged 1 commit into from
Sep 15, 2021

Conversation

ashleyfae
Copy link
Contributor

Fixes #8867

Proposed Changes:

  1. Change return statements to continue. The issue was that it was successfully running the first, then any later failures prevented the next buttons from loading.

@ashleyfae ashleyfae linked an issue Sep 15, 2021 that may be closed by this pull request
PayPal Commerce multiple buy now buttons not working #8867
Closed
@mihaijoldis
Copy link
Contributor

Tested it and its working as intended now!

@ashleyfae
Copy link
Contributor Author

Thanks Mihai. 🙌

robincornett
robincornett approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@robincornett robincornett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I disabled taxes and ran grunt uglify, this worked--the second button originally did not update to a PayPal button and then it did.

@ashleyfae ashleyfae merged commit 0142ab0 into release/2.11.2 Sep 15, 2021
@ashleyfae ashleyfae deleted the issue/8867 branch September 15, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robincornett robincornett robincornett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PayPal Commerce multiple buy now buttons not working
3 participants
@ashleyfae @mihaijoldis @robincornett