Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize all amounts to ensure rounding & formatting #8870 #8881

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Sanitize all amounts to ensure rounding & formatting #8870 #8881

merged 3 commits into from
Sep 22, 2021

Conversation

ashleyfae
Copy link
Contributor

Fixes #8870

Proposed Changes:

  1. Run all amounts through edd_sanitize_amount(), which handles rounding and formatting.

@ashleyfae ashleyfae linked an issue Sep 22, 2021 that may be closed by this pull request
PayPal Commerce: make sure all values are rounded #8870
Closed
robincornett
robincornett requested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@robincornett robincornett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more spot, I think--line 230, we need to run it on the $purchase_data['price'].

@ashleyfae ashleyfae merged commit 28d76fd into release/2.11.2 Sep 22, 2021
@ashleyfae ashleyfae deleted the issue/8870 branch September 22, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robincornett robincornett robincornett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PayPal Commerce: make sure all values are rounded
2 participants
@ashleyfae @robincornett