Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our submenu item to the Dashboard menu list #8898 #8899

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

cklosowski
Copy link
Contributor

Fixes #8898

Proposed Changes:

  1. Adds a 'Reports' menu item under the main Dashboard widget, which links to the EDD Reports view.

@cklosowski
Copy link
Contributor Author

I attempted to do this with add_dashboard_page, however that generates a URL that is for index.php which our reports are not registered for. Our reports are registered for edit.php.

@cklosowski
Copy link
Contributor Author

image

@ashleyfae ashleyfae linked an issue Oct 1, 2021 that may be closed by this pull request
Copy link
Contributor

@ashleyfae ashleyfae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a fan of this change. It feels like we're starting to put our stuff where it doesn't quite belong.

Cod works fine though.

At the very least, should we change the Reports label? Because we're infringing on space that isn't ours, it's not clear what these reports are for. People could have reports for all kinds of stuff: site traffic, affiliates, etc. Do we need an EDD prefix?

@cklosowski
Copy link
Contributor Author

@ashleyfae we could do something like Store Reports or Shop Reports?

EDD Reports is also an option, I think a more generic naming convention there is better (so long as it isn't too generic, as you've pointed out).

@ashleyfae
Copy link
Contributor

EDD 3.0 uses Store in various places, so maybe we should stick with that. I imagine the only conflict there would be if someone is using more than one shop plugin (like EDD + Woo). Which, I'm sure happens, but is minimal.

Copy link
Contributor

@robincornett robincornett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the label needs to be more specific than just "Reports"; adding "Store" works for me.

@cklosowski cklosowski merged commit 4b632fd into release/2.11.3 Oct 1, 2021
@cklosowski cklosowski deleted the issue/8898 branch October 1, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reports menu entry in top level Dashboard menu.
3 participants