Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate individual item name for PayPal when over 127 characters #8912

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Truncate individual item name for PayPal when over 127 characters #8912

merged 1 commit into from
Oct 5, 2021

Conversation

robincornett
Copy link
Contributor

Fixes #8911

Proposed Changes:

  1. Uses substr() to truncate a product item name to 127 characters for PayPal Commerce orders.

@robincornett robincornett linked an issue Oct 4, 2021 that may be closed by this pull request
PayPal purchase can't be completed when product title is too long #8911
Closed
mihaijoldis
mihaijoldis approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@mihaijoldis mihaijoldis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended

@ashleyfae ashleyfae merged commit 8c8c830 into release/2.11.3 Oct 5, 2021
@ashleyfae ashleyfae deleted the issue/8911 branch October 5, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyfae ashleyfae ashleyfae approved these changes

@mihaijoldis mihaijoldis mihaijoldis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PayPal purchase can't be completed when product title is too long
3 participants
@robincornett @mihaijoldis @ashleyfae