Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments added for Translators in multiple files #9762

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mehrazmorshed
Copy link

Adds #

Proposed Changes:

  1. Comments added for Translators in "includes/widgets.php"
  2. Comments added for Translators in "includes/class-edd-download.php"
  3. Comments added for Translators in "includes/api/class-edd-api-v2.php"
  4. Comments added for Translators in "includes/reports/reports-functions.php"
  5. Comments added for Translators in "includes/EDD_SL_Plugin_Updater.php"

@slaFFik
Copy link
Member

slaFFik commented Nov 8, 2024

Hey @mehrazmorshed,

EDD uses a different syntax for that, not like you suggested in your PR:

/* translators: 1: opening anchor tag, do not translate 2. the new plugin version 3. closing anchor tag, do not translate. */

It's in the same includes/widgets.php file you modified, several lines above your suggestion.

EDD teams follows WordPress Codex suggestion: https://codex.wordpress.org/I18n_for_WordPress_Developers#Descriptions

So I think it might be a good idea to change all your // Translators: ... to a more appropriate in this repo /* translators: .... */.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants