Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action fails when GITHUB_REF does not exist #80

Closed
billputer opened this issue Jun 19, 2020 · 4 comments · Fixed by #82
Closed

Action fails when GITHUB_REF does not exist #80

billputer opened this issue Jun 19, 2020 · 4 comments · Fixed by #82
Assignees
@allisaurus

Comments

@billputer
Copy link
Contributor

Certain workflows don't set a GITHUB_REF variable, because the triggering event doesn't have a branch or tag. See GitHub's docs on GITHUB_REF.

However, this action fails with an error when the GITHUB_REF environment variable doesn't exist, with the output ##[error]Missing required environment value. Are you running in GitHub Actions?.
@billputer billputer mentioned this issue Jun 24, 2020
Merged
@piradeepk piradeepk self-assigned this Jun 24, 2020
@piradeepk piradeepk assigned allisaurus and unassigned piradeepk Aug 3, 2020
@bennettl
Copy link

bennettl commented Aug 3, 2020 •
edited
Loading

This is breaking all our pipelines, even if we set role-skip-session-tagging: true its checking for the github env vars which are not set. Not just GITHUB_REF, environment variable

whatsfordinner added a commit to whatsfordinner/vaccine_bot that referenced this issue Aug 4, 2020
@whatsfordinner
manually setting GITHUB_ACTION to true: aws-actions/configure-aws-cre…
dc2e922 
…dentials#80
whatsfordinner added a commit to whatsfordinner/vaccine_bot that referenced this issue Aug 4, 2020
@whatsfordinner
Revert "manually setting GITHUB_ACTION to true: aws-actions/configure…
d38ad2f 
…-aws-credentials#80"

You're unable to set environment variables with the GITHUB_ prefix, should have RTFM

This reverts commit dc2e922.
@allisaurus
Copy link
Contributor

Thanks for reporting @sergirosell & @bennettl - sounds like the issue with the runner was rolled back, but we're working on fixing this for GITHUB_REF and the other env vars when tagging is skipped.

@mergify mergify bot closed this as completed in #82 Aug 4, 2020
@allisaurus
Copy link
Contributor

FYI we are tracking issues with remaining env vars here: #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allisaurus allisaurus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make GITHUB_REF env var optional billputer/configure-aws-credentials
5 participants
@billputer @bennettl @allisaurus @piradeepk and others