use execa Options

aws-amplify · Jan 27, 2024 · 30cd61e · 30cd61e
1 parent a234d1b
commit 30cd61e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 19 deletions.
diff --git a/packages/cli-core/src/package-manager-controller/package_manager_controller_base.ts b/packages/cli-core/src/package-manager-controller/package_manager_controller_base.ts
@@ -1,6 +1,6 @@
 import { existsSync as _existsSync } from 'fs';
 import _fsp from 'fs/promises';
-import { ExecaChildProcess, execa as _execa } from 'execa';
+import { ExecaChildProcess, type Options, execa as _execa } from 'execa';
 import * as _path from 'path';
 import { type PackageManagerController } from '@aws-amplify/plugin-types';
 import { LogLevel } from '../printer/printer.js';
@@ -123,13 +123,7 @@ Get started by running \`${this.binaryRunner} amplify sandbox\`.`;
   runWithPackageManager(
     args: string[] = [],
     dir: string,
-    options?: {
-      env?: Record<string, string>;
-      stdin?: 'inherit' | 'pipe' | 'ignore';
-      stdout?: 'inherit' | 'pipe' | 'ignore';
-      stderr?: 'inherit' | 'pipe' | 'ignore';
-      extendEnv?: boolean;
-    }
+    options?: Options
   ): ExecaChildProcess<string> {
     return this.executeWithDebugLogger(
       dir,

diff --git a/packages/integration-tests/src/process-controller/process_controller.ts b/packages/integration-tests/src/process-controller/process_controller.ts
@@ -172,9 +172,7 @@ export const runWithPackageManager = (
   packageManager: PackageManager,
   args: string[] = [],
   dir: string,
-  options?: {
-    env?: Record<string, string>;
-  }
+  options?: Options
 ): ProcessController => {
   let packageManagerBinary: PackageManagerExecutable;
   switch (packageManager) {

diff --git a/packages/plugin-types/src/package_manager_controller.ts b/packages/plugin-types/src/package_manager_controller.ts
@@ -3,7 +3,7 @@
  * execa v8 doesn't support commonjs, so we need to use the types from v5
  * https://github.com/sindresorhus/execa/issues/489#issuecomment-1109983390
  */
-import { type ExecaChildProcess } from 'execa';
+import { type ExecaChildProcess, type Options } from 'execa';
 
 export type DependencyType = 'dev' | 'prod';
 
@@ -19,12 +19,6 @@ export type PackageManagerController = {
   runWithPackageManager: (
     args: string[] | undefined,
     dir: string,
-    options?: {
-      env?: Record<string, string>;
-      stdin?: 'inherit' | 'pipe' | 'ignore';
-      stdout?: 'inherit' | 'pipe' | 'ignore';
-      stderr?: 'inherit' | 'pipe' | 'ignore';
-      extendEnv?: boolean;
-    }
+    options?: Options
   ) => ExecaChildProcess<string>;
 };