Exposing stack parameter at higher level for backend and related resources #2021
Conversation
This reverts commit 80c981e.
🦋 Changeset detectedLatest commit: 24eff8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 79678cc.
This reverts commit 558692f.
.changeset/four-drinks-yell.md
Outdated
| --- | ||
| '@aws-amplify/integration-tests': minor | ||
| '@aws-amplify/backend-storage': minor | ||
| '@aws-amplify/plugin-types': minor | ||
| --- | ||
|
|
||
| add new type to handle exposing stack, expose stack in storage |
There was a problem hiding this comment.
We can remove integration-tests from changesets.
I'd move storage from this changeset to the other one. and keep this one for plugin types only.
It'll generate more coherent changelogs.
| @@ -157,5 +159,6 @@ export const defineBackend = <T extends DefineBackendProps>( | |||
| ...backend.resources, | |||
| createStack: backend.createStack, | |||
| addOutput: backend.addOutput, | |||
| stack: backend.mainStack, | |||
There was a problem hiding this comment.
| stack: backend.mainStack, | |
| stack: backend.stack, |
if we're going with just stack let's keep naming consistent on backend factory as well.
| const functionStack = Stack.of( | ||
| functionFactory.getInstance(getInstanceProps).resources.lambda | ||
| functionFactory.getInstance(getInstanceProps).stack | ||
| ); |
There was a problem hiding this comment.
nit: do we need Stack.of here?
There was a problem hiding this comment.
no, we don't, that would be a quick thing for me to fix since that looks like the only instance where I didn't properly remove Stack.of
ShadowCat567
dismissed stale reviews from Amplifiyer and sobolk
via
24eff8a
|
Any reason the data category was not included in this PR for lifting the stack parameter? |
@Amplifiyer It's coming . See aws-amplify/amplify-category-api#2899 We typed the factory with full |
Problem
Users would like to be able to easily access the root stack and the stacks of their resources. Helpful for adding tags.
Issue number, if available: #1535 #1242
Changes
Corresponding docs PR, if applicable:
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.