update fallback for backend id resolvers if stack, app id, or branch are in args #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 249206c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sobolk
previously approved these changes
Sep 20, 2024
Amplifiyer
reviewed
Sep 20, 2024
| @@ -18,23 +18,25 @@ export class BackendIdentifierResolverWithFallback | |||
| private fallbackResolver: SandboxBackendIdResolver | |||
| ) {} | |||
| /** | |||
| * resolves the backend id, falling back to the sandbox id if there is an error | |||
| * resolves to deployed backend id, falling back to the sandbox id if there is an error and stack, appId, and branch are not provided | |||
There was a problem hiding this comment.
We are not falling back on errors
Suggested change
| * resolves to deployed backend id, falling back to the sandbox id if there is an error and stack, appId, and branch are not provided | |
| * resolves to deployed backend id, falling back to the sandbox id if stack or appId and branch inputs are not provided |
| (await this.fallbackResolver.resolve()) | ||
| ); | ||
| if (args.stack || args.appId || args.branch) { | ||
| return await this.defaultResolver.resolveDeployedBackendIdentifier(args); |
There was a problem hiding this comment.
no need to await if we are not doing error handling.
There was a problem hiding this comment.
We could possibly be throwing an error in the namespace resolver.
There was a problem hiding this comment.
that will be caught by the caller when they await this method.
Amplifiyer
approved these changes
Sep 20, 2024
sobolk
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Came from #2028 (comment).
If stack, app id, or branch are passed in as an argument for generate commands, there is no intention to run these commands against a sandbox.
Issue number, if available:
Changes
Only fallback to resolving sandbox backend identifier if stack, app id, and branch are not passed in as arguments to generate commands.
Corresponding docs PR, if applicable:
Validation
Updated unit test.
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.