feed pr base sha and ref into envs before scripts #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4a4680 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ShadowCat567
previously approved these changes
Oct 30, 2024
sobolk
reviewed
Oct 30, 2024
There was a problem hiding this comment.
this file is empty. is this intentional ?
There was a problem hiding this comment.
Whoops, that was accidentally added. Removing it.
sobolk
approved these changes
Oct 30, 2024
Comment on lines
+433
to
+434
| env: | ||
| BASE_SHA: ${{ github.event.pull_request.base.sha }} |
There was a problem hiding this comment.
the change is fine but for this particular field it seems overkill.
I.e. this particular filed on the event is not containing user data.
awsluja
approved these changes
Oct 30, 2024
sobolk
pushed a commit
that referenced
this pull request
Nov 4, 2024
* feed pr base sha and ref into envs before scripts * removing empty file
sobolk
pushed a commit
that referenced
this pull request
Nov 4, 2024
* feed pr base sha and ref into envs before scripts * removing empty file
sobolk
pushed a commit
that referenced
this pull request
Nov 7, 2024
* feed pr base sha and ref into envs before scripts * removing empty file
sobolk
pushed a commit
that referenced
this pull request
Nov 7, 2024
* feed pr base sha and ref into envs before scripts * removing empty file
awsluja
added a commit
that referenced
this pull request
Nov 7, 2024
* chore: add working setup for e2e resources in ref auth * feed pr base sha and ref into envs before scripts (#2168) * feed pr base sha and ref into envs before scripts * removing empty file * chore: update names to use test prefix * chore: remove extra hyphen * chore: fix cleanup and add sandbox test * chore: make sure to throw if error describing stack is unknown --------- Co-authored-by: Roshane Pascual <[email protected]>
awsluja
added a commit
that referenced
this pull request
Nov 11, 2024
* feat: reference auth basic setup * chore: factory basic tests * chore: update api * chore: add ref auth package as dependency to backend-auth * chore: lint * chore: add tests for construct * chore: cleanup tsconfig * chore: add changeset * chore: fix tests inputs * chore: update tests * fix: update resource provider types * chore: update api * feat: reference auth outputs * chore: add tests * chore: fix test * chore: cleanup reused variables * chore: changeset * chore: cleanup changeset * chore: cleanup * chore: cleanup changesets, lockfile, and api * chore: fix mismatched output structure * chore: refactor and add tests * chore: add more tests for identity pool errors * chore: cleanup * chore: fix test * chore: add role tests * chore: add tests for user pool client * chore: cleanup * chore: refactor * chore: fix api * chore: undo changes to concurrent workspace script * chore: add missing roles permission * chore: update expected IAM policy permissions for identity pool * fix: make sure to throw on errors when using Provider framework * chore: refactor * chore: cleanup * chore: more cleanup * chore: check for alias attributes and fix tests * chore: add support for validating group roles exist for user pool * chore: update package-lock file * chore: add checks for oauth validation * chore: fix typo * chore: eliminate forcing updates on any change * chore: remove commented out code * chore: merge factory count into single count for all auth factories * chore: move sample data and npmignore it * chore: cleanup * chore: fix path * chore: update package lock * chore: update package-lock * chore: move construct into backend-auth * chore: update api * chore: update changeset * chore: cleanup * chore: move props type to factory * chore: add working setup for e2e resources in ref auth (#2122) * chore: add working setup for e2e resources in ref auth * feed pr base sha and ref into envs before scripts (#2168) * feed pr base sha and ref into envs before scripts * removing empty file * chore: update names to use test prefix * chore: remove extra hyphen * chore: fix cleanup and add sandbox test * chore: make sure to throw if error describing stack is unknown --------- Co-authored-by: Roshane Pascual <[email protected]> * chore: add bsd-3-clause-clear license to allow list * chore: cleanup * chore: make lambda deps dev dependencies * chore: revert license changes * chore: remove tag mechanism as not needed for cleanup --------- Co-authored-by: Roshane Pascual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Passing potentially untrusted inputs to intermediate environment variables before passing to commands as suggested in https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable.
Corresponding docs PR, if applicable:
Validation
Health checks on this PR.
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.