Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid client config generation race condition #2184

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Nov 1, 2024

Problem

There seems to be a race condition between client config generation and asserting post deployment, sometimes we see this error:
Screenshot 2024-11-01 at 10 33 02 AM

Compared to a successful run:
Screenshot 2024-11-01 at 10 41 28 AM

Issue number, if available:

Changes

Use existing waitForConfigUpdateAfterDeployment action to wait for amplify_outputs.json to be generated before interrupting sandbox and asserting post deployment.

Also following #2160, removed the rejectCleanupSandbox action since the prompt no longer exists.

Corresponding docs PR, if applicable:

Validation

E2E tests and canary test run https://github.com/aws-amplify/amplify-backend/actions/runs/11635102140.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rtpascual rtpascual added the run-e2e Label that will include e2e tests in PR checks workflow label Nov 1, 2024
@rtpascual rtpascual requested a review from a team as a code owner November 1, 2024 17:46
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 1ec2c61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sobolk
sobolk previously approved these changes Nov 1, 2024
@rtpascual rtpascual merged commit b9575eb into main Nov 1, 2024
70 checks passed
@rtpascual rtpascual deleted the config-race-condition branch November 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants