Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parameter not found error while deleting secret #2186

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Nov 1, 2024

Problem

Two errors are misclassified as faults while removing secrets:

  1. When ssm parameter does not exist.
  2. Another variant of invalid credentials.

Changes

Added handling logic.

Validation

Existing tests + new test.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner November 1, 2024 20:20
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: d71507b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-secret Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk enabled auto-merge (squash) November 1, 2024 20:33
@sobolk sobolk merged commit 255ca18 into main Nov 1, 2024
40 checks passed
@sobolk sobolk deleted the secret-delete-fixes branch November 1, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants