Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e tests #771

Merged
merged 44 commits into from
Dec 6, 2023
Merged

fix: e2e tests #771

Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
6577ebf
chore: change branch to poc/pms-create-amplify
0618 Nov 28, 2023
63e498b
fix: gitIgnore test
0618 Nov 28, 2023
2649b52
Merge branch 'main' into poc/pms-create-amplify
0618 Nov 28, 2023
b12306f
fix: refactor e2e for pms
0618 Nov 28, 2023
0fdb132
chore: update package.lock
0618 Nov 28, 2023
dfe3aab
Merge branch 'main' into poc/pms-create-amplify
0618 Nov 28, 2023
5023934
chore: update package.lock
0618 Nov 29, 2023
12c183b
temp: refactor
0618 Nov 28, 2023
020f87a
temp: run 1 test
0618 Nov 29, 2023
1ca1400
temp: fix npx
0618 Nov 29, 2023
307e613
temp: install packages for yarn
0618 Nov 29, 2023
7d9537b
temp: update initial_project_file_generator
0618 Nov 29, 2023
333d33d
temp: install ts for yarn
0618 Nov 29, 2023
ab0af4e
temp: ignore node_modules and yarn.lock
0618 Nov 29, 2023
43ec0c6
temp: create yarn.lock for yarn stable
0618 Nov 29, 2023
efcbca4
temp: fix yarn-stable init
0618 Nov 29, 2023
5fc04ca
temp: fix --help
0618 Nov 29, 2023
2ab3397
fix: assert for gitignore
0618 Nov 29, 2023
d4e52ba
chore: change yarn stable install
0618 Nov 30, 2023
1c1ca48
Merge branch 'main' into poc/pms-create-amplify
0618 Nov 30, 2023
4a1a848
fix: not install yarn stable globally
0618 Dec 1, 2023
15fa887
add @yarnpkg/sdks base
0618 Dec 2, 2023
d25ba85
yarn stable use node-modules
0618 Dec 3, 2023
068c40b
remove emoji
0618 Dec 3, 2023
6a994f0
remove @yarnpkg/sdks
0618 Dec 3, 2023
430f0a1
yarn stable use node 18.18
0618 Dec 4, 2023
f1eb76a
yarn stable use node 20
0618 Dec 4, 2023
f7a167b
chore: re-enable all tests
0618 Dec 4, 2023
7d9bb78
Revert "chore: re-enable all tests"
0618 Dec 4, 2023
8edfb56
Merge branch 'poc/package-manager-support' into poc/pms-create-amplify
0618 Dec 4, 2023
26fe239
chore: uncomment test
0618 Dec 4, 2023
69aa2d4
chore: enable all initialStatues
0618 Dec 4, 2023
81d285d
test: change concurrencyLevel for yarn and yarn stable
0618 Dec 5, 2023
f45b6c8
add yarn-stable to test fails fast
0618 Dec 5, 2023
45090b2
chore: update changeset
0618 Dec 5, 2023
ac452fb
chore: change workflow trigger
0618 Dec 5, 2023
4728a4c
Merge branch 'main' into poc/fix-e2e
0618 Dec 5, 2023
0d83dd0
chore: yarn not install typescript in root folder
0618 Dec 5, 2023
5829bd3
chore: update package.lock
0618 Dec 5, 2023
ddf9e6c
Revert "chore: yarn not install typescript in root folder"
0618 Dec 5, 2023
e88dbee
chore: remove comment
0618 Dec 5, 2023
35ad270
Merge branch 'poc/package-manager-support' into poc/fix-e2e
0618 Dec 5, 2023
338457d
chore: fix typo
0618 Dec 5, 2023
f98ddb9
chore: rename yarn-classic and yarn modern
0618 Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .changeset/curly-toes-doubt.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/few-carpets-search.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/few-pillows-pay.md
View file
Open in desktop

This file was deleted.

0 .changeset/eight-bags-walk.md → .changeset/itchy-pigs-switch.md
View file
Open in desktop
File renamed without changes.
7 changes: 0 additions & 7 deletions .changeset/mighty-bottles-leave.md
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/mighty-rockets-shake.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/plenty-maps-doubt.md
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .changeset/proud-vans-protect.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/rotten-swans-study.md
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .changeset/young-cherries-know.md
View file
Open in desktop

This file was deleted.

17 changes: 5 additions & 12 deletions .github/workflows/poc-e2e-flow-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ name: 'poc-e2e-flow-test'
on: # TODO: need to change the trigger
push:
branches:
- poc/e2e-create-amplify
- poc/package-manager-support
pull_request:
branches:
- poc/package-manager-support

jobs:
install:
Expand Down Expand Up @@ -37,18 +40,8 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
pkg-manager: [npm, yarn, pnpm]
pkg-manager: [npm, yarn, yarn-stable, pnpm]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the discussion from the demo, can we name these something like yarn-classic and yarn-modern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed f98ddb9

node-version: [20]
include:
- os: ubuntu-latest
pkg-manager: yarn-stable
node-version: 19 # TODO: use Node 20 once https://github.com/yarnpkg/berry/pull/5961 is released
- os: macos-latest
pkg-manager: yarn-stable
node-version: 19 # TODO: use Node 20 once https://github.com/yarnpkg/berry/pull/5961 is released
- os: windows-latest
pkg-manager: yarn-stable
node-version: 19 # TODO: use Node 20 once https://github.com/yarnpkg/berry/pull/5961 is released
env:
ACKAGE_MANAGER_EXECUTABLE: ${{ matrix.pkg-manager }} # TODO: remove PACKAGE_MANAGER_EXECUTABLE once CLI is able to getPackageManager().
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize it's not part of this PR, but this seems to be setting the wrong env var

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!! It's weird that the test ran as expected even with the wrong var name 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see ${{ matrix.pkg-manager }} was directly passed to the env var in the commend line. Github env var has never been used

runs-on: ${{ matrix.os }}
Expand Down
Loading
Loading