Remove activity related flags in notification intent #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
added
pinpoint
|
This pull request introduces 2 alerts when merging bf2423d into 23082a3 - view on LGTM.com new alerts:
|
raphkim
approved these changes
Dec 9, 2019
TrekSoft
approved these changes
Dec 9, 2019
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
* Remove activity related flags in notification intent * Remove activity related flags in notification intent * Remove activity related flags in notification intent * Delete dbnavigator.xml * Update NotificationClientBase.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed setting of activity related flags in the notification intent being created. The activity related flags are useful when an activity launches an other activity that is already in the Android activity stack. However, the intent that is being created is not used for communicating with an activity and instead used for service and broadcast. Hence, this comes down to the problem of setting activity related flags in a pending intent which is not used for communicating with an activity.
A customer found crashes while setting these flags in Android < 4.4. However >= 4.4, Android prevented the crash and made it a no-op.
The fix proposed here removes the flags and variable renaming and indentation fixes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.