Expose Client Configuration in API Factory and prevent user agent being overridden #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred <[email protected]>
Signed-off-by: Fred <[email protected]>
…-factory Expose client config in api gateway factory
Signed-off-by: Fred <[email protected]>
…iguration Ensure we always have a client configuration
|
thanks, lgtm +1 |
Signed-off-by: Fred <[email protected]>
…iguration Remove previously added formatting
Signed-off-by: Fred <[email protected]>
|
I'm closing this PR so I can separate the 2 features in 2 prs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a lot of client identification based on user agent in our api requests. Unfortunately the sdk was overriding this.
This PR prevents this so that if there's a parameter present in the client interface that sets the user agent, then we don't override it. In other words, if an interface is defined as such:
Then the user agent is not overridden.
The PR also exposes the
ClientConfigurationin theApiClientFactoryto allow for higher flexibility. In our use case we use it to set the user agent for all clients by default and have the above way to specify it per call.I'm not sure how to handle versioning here, let me know if you'd like me to bump it.