[Core] Remove call to setkeySize in KeyProvider18 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
added
core
minbi
reviewed
May 20, 2019
| @@ -151,7 +151,6 @@ private void initializeRSAKeyFromKeyStore(Context context, | |||
| .setSerialNumber(BigInteger.TEN) | |||
| .setStartDate(start.getTime()) | |||
| .setEndDate(end.getTime()) | |||
| .setKeySize(RSA_KEY_SIZE) | |||
There was a problem hiding this comment.
The RSA_KEY_SIZE constant definition should also be removed. Potentially update the javadoc regarding the key size and how the default is used. Did we rule out splitting KeyProvider18 into 18 and 19?
There was a problem hiding this comment.
Removed the constant and updated the Javadoc. Since the default key size is 2048 bits, I recommend to not invoke the method and keep the implementation the same for 18-22.
There was a problem hiding this comment.
Agreed. The default size will not be lowered in the future.
mutablealligator
force-pushed
the
keystore-fix
branch
from
0967000
to
235bfb6
Compare
SalusaSecondus
approved these changes
May 20, 2019
…ng key-pair for KeyProvider18'
minbi
approved these changes
May 20, 2019
mutablealligator
force-pushed
the
keystore-fix
branch
2 times, most recently
from
510b615
to
b101c43
Compare
minbi
reviewed
May 21, 2019
mutablealligator
force-pushed
the
keystore-fix
branch
from
b101c43
to
78f9ebd
Compare
mutablealligator
force-pushed
the
keystore-fix
branch
from
78f9ebd
to
7f31921
Compare
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#964
Description of changes:
setKeySizeis not available in API Level 18. The default key size used by RSA inKeyPairGeneratorSpecis 2048 when not specified. This change will use the default of 2048 in all API levels (18-22).Added build automation for verifying if the fix works for API 18-22.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.