Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goroutine leak in aws-sdk-go library #1512

Closed
a-hilaly opened this issue Oct 18, 2022 · 4 comments
Closed

Goroutine leak in aws-sdk-go library #1512

a-hilaly opened this issue Oct 18, 2022 · 4 comments
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@a-hilaly
Copy link
Member

a-hilaly commented Oct 18, 2022 •
edited
Loading

@embano1 brought to our attention this issue that reported a goroutine leak in the aws-sdk-go library see aws/aws-sdk-go#3606. It looks like the bug was fixed in aws-sdk-go-v2 but no the v1 library. We need to bring this in our next community meeting 10-20-22.
/cc @aws-controllers-k8s/runtime-maintainer
@a-hilaly a-hilaly added kind/bug Categorizes issue or PR as related to a bug. area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 18, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 16, 2023

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2023
@jljaco
Copy link
Contributor

jljaco commented Feb 15, 2023

We don't think that we have a codepath where we have yet seen this happen. Setting this to a long-term priority

@jljaco jljaco added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2023
@a-hilaly
Copy link
Member Author

we're moving to aws-sdk-go v2 - closing as this is no longer relevant
/close

@ack-prow ack-prow bot closed this as completed Jun 28, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jun 28, 2024

@a-hilaly: Closing this issue.

In response to this:

we're moving to aws-sdk-go v2 - closing as this is no longer relevant
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a-hilaly @ack-bot @jljaco