Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Maya 2025 submitter support #183

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Conversation

dzavada
Copy link
Contributor

@dzavada dzavada commented Oct 17, 2024

Fixes #180

I modified several files to convert from PySide2 to QtPy, ensuring compatibility with both Maya 2025 and 2024. I've thoroughly tested the updates on both Windows and Linux systems to confirm everything works as expected.

delete text starting here
Please ensure that you have read through the contributing guidelines before continuing.
delete text ending here

Fixes:

What was the problem/requirement? (What/Why)

What was the solution? (How)

What is the impact of this change?

How was this change tested?

delete text starting here
See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests?
    delete text ending here

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

delete text starting here
See the "Integration Tests" subsection of the
Running Submitter Tests
section of DEVELOPMENT.md for information on these tests.

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

delete text ending here

Was this change documented?

delete text starting here

  • Did you update all relevant docstrings for Python functions that you modified?
  • Should the README.md, DEVELOPMENT.md, or other documents in the repository's docs/ directory be updated along with your change?
  • Should the schema files for the adaptor's init-data or run-data be updated?
    delete text ending here

Is this a breaking change?

delete text starting here
A breaking change is one that modifies a public contract in some way or otherwise changes functionality of this application in a way
that is not backwards compatible. Examples of changes that are breaking include:

  1. Adding a new required value to the init-data or run-data of the adaptor;
  2. Deleting or renaming a value in the init-data or run-data of the adaptor; and
  3. Otherwise modifying the interface of the adaptor such that a job submitted with an older version of the Maya submitter plug-in
    will not work with a version of the adaptor that includes your modification.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications. Also,
please ensure that the title of your commit follows our conventional commit guidelines in
CONTRIBUTING.md for breaking changes.
delete text ending here


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dzavada dzavada requested a review from a team as a code owner October 17, 2024 00:56
Copy link
Contributor

@mwiebe mwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR! It looks like there might be some merge/rebase changes going on in the test runner and maybe the LayerSelection code, can you double check that?

@epmog epmog changed the title Update to Feature request: Maya 2025 Integrated submitter support #180 Fix PySide2 errors feat: add Maya 2025 submitter support Oct 17, 2024
dzavada and others added 7 commits October 28, 2024 10:29
…mpatibility with both Maya 2025 and 2024. I've thoroughly tested the updates on both Windows and Linux systems to confirm everything works as expected.

Signed-off-by: dzavada <[email protected]>
Revert some rebase changes
Add missing newline that is making linting fail
Fixing linting
Copy link

sonarcloud bot commented Oct 28, 2024

Copy link
Contributor

@mwiebe mwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overrode the DCO check because it fails on the commits applied by the github interface.

@epmog epmog merged commit a4fc035 into aws-deadline:mainline Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Maya 2025 Integrated submitter support
3 participants