Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set optionVar value to default before running tests, small additional fixes #91

Open
wants to merge 5 commits into
base: mainline
Choose a base branch
from

Conversation

rmv
Copy link
Contributor

@rmv rmv commented Feb 12, 2024

What was the problem/requirement? (What/Why)

  • Bundle tests rely on a maya option var that is saved in preferences, not scene file.
  • When the report file path is shown, the report is not yet created.
  • Macos does not show Qt dialog window titles.
  • Coverage tests include some test code.

What was the solution? (How)

  • Set the option Var to its default value before running the tests.
  • Before reporting the report file location, make sure it's fully written out.
  • Repeat the title info in dialog body.
  • Omit test code from coverage testing.

What is the impact of this change?

More reliable output bundle tests, minor qol fixes for devs.

How was this change tested?

Ran the bundle output tests in failure and success modes.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Yes.

Was this change documented?

No

Is this a breaking change?

No

@rmv rmv marked this pull request as ready for review February 12, 2024 21:25
@rmv rmv requested a review from a team as a code owner February 12, 2024 21:25
@epmog
Copy link
Contributor

epmog commented Mar 15, 2024

I ended up with a very similar fix in #103 that got merged and didn't see that the work was already done here. Closing this. actually there's other fixes in here that we want in

@epmog epmog closed this Mar 15, 2024
@epmog epmog reopened this Mar 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants