feat: support JSON output in bundle GUI submitter #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
reviewed
Jun 20, 2024
lucaseck
reviewed
Jun 21, 2024
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
Signed-off-by: Stephen Crowe <[email protected]>
moorec-aws
approved these changes
Jun 24, 2024
lucaseck
approved these changes
Jun 24, 2024
Merged
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 25, 2024
* feat: support JSON output in bundle GUI submitter Signed-off-by: Stephen Crowe <[email protected]> Signed-off-by: Cloud User <[email protected]>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 26, 2024
* feat: support JSON output in bundle GUI submitter Signed-off-by: Stephen Crowe <[email protected]> Signed-off-by: Cloud User <[email protected]>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 26, 2024
* feat: support JSON output in bundle GUI submitter Signed-off-by: Stephen Crowe <[email protected]> Signed-off-by: Cloud User <[email protected]>
epmog
added a commit
to epmog/deadline-cloud
that referenced
this pull request
Jun 26, 2024
…ine#357)" This reverts commit aad9a49. Signed-off-by: Morgan Epp <[email protected]>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jun 26, 2024
…deadline#344) * fix: bundles are stored in job_history in their original format Signed-off-by: Stephen Crowe <[email protected]> fix: use sids when granting permissions with icacls (aws-deadline#359) Signed-off-by: Charles Moore <[email protected]> Signed-off-by: Cloud User <[email protected]> chore: Add OS field support for integ test (aws-deadline#361) Signed-off-by: Alex Tran <[email protected]> Signed-off-by: Cloud User <[email protected]> fix: bundle gui-submit fails loading bundles with saved queue parameter values (aws-deadline#360) Signed-off-by: Evan Spearman <[email protected]> Signed-off-by: Cloud User <[email protected]> ci: update workflow job names for integ tests (aws-deadline#338) Signed-off-by: Charles Moore <[email protected]> Signed-off-by: Cloud User <[email protected]> Squish Automated Tests - Settings flow for Dev Submit GUI Change env var to relative path Squish Automated Tests - Dev Submit GUI Settings Flow Squish Automated Tests - Dev Submit GUI settings flow Signed-off-by: Cloud User <[email protected]> ci: Add integ req to toml (aws-deadline#364) Signed-off-by: Alex Tran <[email protected]> Signed-off-by: Cloud User <[email protected]> Fixing linting errors Signed-off-by: Cloud User <[email protected]> feat: support JSON output in bundle GUI submitter (aws-deadline#357) * feat: support JSON output in bundle GUI submitter Signed-off-by: Stephen Crowe <[email protected]> Signed-off-by: Cloud User <[email protected]> fixing formatting/lint issues Signed-off-by: Cloud User <[email protected]> fixing linting issues Signed-off-by: Cloud User <[email protected]> fixing linting errors Signed-off-by: Cloud User <[email protected]> chore(release): 0.48.5 (aws-deadline#367) Signed-off-by: client-software-ci <[email protected]> Signed-off-by: Cloud User <[email protected]> chore(deps): update python-semantic-release requirement (aws-deadline#342) Updates the requirements on [python-semantic-release](https://github.com/python-semantic-release/python-semantic-release) to permit the latest version. - [Release notes](https://github.com/python-semantic-release/python-semantic-release/releases) - [Changelog](https://github.com/python-semantic-release/python-semantic-release/blob/master/CHANGELOG.md) - [Commits](python-semantic-release/python-semantic-release@v9.5.0...v9.8.1) --- updated-dependencies: - dependency-name: python-semantic-release dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Cloud User <[email protected]> Disabling lint error checks due to Squish modules Signed-off-by: Cloud User <[email protected]> feat: Adding automated tests using Squish framework: Dev Submit GUI Settings flow Signed-off-by: Cloud User <[email protected]> feat: Adding automated tests using Squish framework: Dev Submit GUI Settings flow Signed-off-by: Cloud User <[email protected]>
moorec-aws
pushed a commit
to epmog/deadline-cloud
that referenced
this pull request
Jun 26, 2024
…ine#357)" This reverts commit aad9a49. Signed-off-by: Morgan Epp <[email protected]>
moorec-aws
pushed a commit
that referenced
this pull request
Jun 26, 2024
* revert: "feat: support JSON output in bundle GUI submitter (#357)" This reverts commit aad9a49. Signed-off-by: Morgan Epp <[email protected]> * revert: "chore(deps): update jsonschema requirement from ==4.17.* to >=4.17,<4.23 (#336)" This reverts commit 369ec40. Signed-off-by: Morgan Epp <[email protected]> --------- Signed-off-by: Morgan Epp <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In a DCC integration, I was trying to read out the most recently submitted job settings. The bundle GUI submitter prints a human readable output with the bundle directory path where the settings can be found. but the response is not machine readable.
What was the solution? (How)
Add a JSON output option.
What is the impact of this change?
Scripts calling the GUI submitter can easily read back where the job bundle is saved and what the submitted job ID is.
How was this change tested?
Unit tests and manually running the CLI commands.
Was this change documented?
Auto-documented in the CLI help.
Is this a breaking change?
No - new minor feature.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.