feat: Run Integration tests on Windows as well #381
Merged
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
previously approved these changes
Jun 27, 2024
jericht
reviewed
Jun 27, 2024
|
Signed-off-by: Yutong Li <[email protected]>
YutongLi291
changed the title
moorec-aws
approved these changes
Jun 27, 2024
jericht
approved these changes
Jun 28, 2024
Merged
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Yutong Li <[email protected]> Signed-off-by: Cloud User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We have successfully fixed the integration tests that are being ran for Job Attachments (which are currently the only integ tests in this repo) on Linux. We would like to add this workflow to also run on Windows.
What was the solution? (How)
Add it to the actions
What is the impact of this change?
We can verify if the tests run properly on Windows
How was this change tested?
The linux workflow was tested https://github.com/aws-deadline/deadline-cloud/actions/runs/9704180168 to verify that it works
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.