fix: Fix JA wrong account bucket integration test temp path name #385
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <[email protected]>
marofke
approved these changes
Jul 2, 2024
AlexTranAmz
approved these changes
Jul 2, 2024
leongdl
reviewed
Jul 2, 2024
| @@ -1355,7 +1355,7 @@ def test_sync_inputs_bucket_wrong_account( | |||
| ) | |||
|
|
|||
| syncer = asset_sync.AssetSync(job_attachment_test.farm_id) | |||
| session_dir = tmp_path_factory.mktemp(r"An error occurred \(403\)") | |||
There was a problem hiding this comment.
Was this written as a funky folder for a reason before?
There was a problem hiding this comment.
It doesn't make sense to have a funky folder since it doesn't have anything to do with what the test is testing
There was a problem hiding this comment.
Even if there is a reason, it's most likely not needed anymore as we already have a regex check to make sure char like "(" and "" can't be used
There was a problem hiding this comment.
Perfect - this would make sense now.
|
This fixed the integration tests completely https://github.com/aws-deadline/deadline-cloud/actions/runs/9765921768 |
leongdl
reviewed
Jul 2, 2024
Merged
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jul 9, 2024
…-deadline#385) Signed-off-by: Yutong Li <[email protected]> Signed-off-by: Cloud User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The windows integration tests were failing due to
FAILED test/integ/deadline_job_attachments/test_job_attachments.py::test_sync_inputs_bucket_wrong_account[2023-03-03] - ValueError: An error occurred \(403\) is not a normalized and relative pathWhat was the solution? (How)
Fix the test which is creating a temp path with a weird path to just use a normal path
What is the impact of this change?
The tests should pass on windows.
How was this change tested?
No windows environment, but confirmed that mac tests still work properly by
hatch run integ:testWas this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.