-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: record Success-Fail telemetry event on job attachments upload and download. #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leongdl
changed the title
Record Success-Fail telemetry event on job attachments upload and download.
feat: record Success-Fail telemetry event on job attachments upload and download.
Jul 5, 2024
leongdl
force-pushed
the
telemetry
branch
2 times, most recently
from
July 8, 2024 19:19
466b70c
to
d731262
Compare
leongdl
commented
Jul 9, 2024
@@ -349,3 +353,35 @@ def get_deadline_cloud_library_telemetry_client( | |||
:return: Telemetry client to make requests with. | |||
""" | |||
return get_telemetry_client("deadline-cloud-library", version, config=config) | |||
|
|||
|
|||
def record_success_fail_telemetry_event(**decorator_kwargs: Dict[str, Any]) -> Callable[..., F]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this a decorator so we can tag any code path to emit success / fail from now on.
crowecawcaw
previously approved these changes
Jul 9, 2024
benl-2023
reviewed
Jul 10, 2024
YutongLi291
previously approved these changes
Jul 10, 2024
benl-2023
reviewed
Jul 10, 2024
benl-2023
approved these changes
Jul 10, 2024
crowecawcaw
approved these changes
Jul 10, 2024
Signed-off-by: David Leong <[email protected]>
github-actions bot
pushed a commit
to Ahuge/deadline-cloud
that referenced
this pull request
Jul 11, 2024
…ws-deadline#393) Signed-off-by: David Leong <[email protected]>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jul 17, 2024
…ws-deadline#393) Signed-off-by: David Leong <[email protected]> Signed-off-by: Cloud User <[email protected]>
Merged
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Aug 26, 2024
…ws-deadline#393) Signed-off-by: David Leong <[email protected]> Signed-off-by: Cloud User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
What was the solution? (How)
What is the impact of this change?
How was this change tested?
Manual testing:
Was this change documented?
Is this a breaking change?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.