chore: add pyinstaller hidden import #400
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucaseck <[email protected]>
epmog
approved these changes
Jul 10, 2024
AWS-Samuel
approved these changes
Jul 10, 2024
github-actions bot
pushed a commit
to Ahuge/deadline-cloud
that referenced
this pull request
Jul 12, 2024
Signed-off-by: lucaseck <[email protected]>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jul 17, 2024
Signed-off-by: lucaseck <[email protected]> Signed-off-by: Cloud User <[email protected]>
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Aug 26, 2024
Signed-off-by: lucaseck <[email protected]> Signed-off-by: Cloud User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Pyinstaller versions < 6.7.0 aren't detecting a required import when bundling everything together and using versions of setuptools > 70.
What was the solution? (How)
Folowing the instructions from the initial Pyinstaller bug report I've added the missing import as a hidden import
pyinstaller/pyinstaller#8554
What is the impact of this change?
Fixed installer build process
How was this change tested?
Built an installer myself and verified the changes
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.