feat: adds --storage-profile-id option to the bundle submit command #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
force-pushed
the
submit_storage_profile_id
branch
3 times, most recently
from
aec257a
to
8f96ca0
Compare
leongdl
previously approved these changes
Sep 6, 2024
epmog
reviewed
Sep 6, 2024
ddneilson
force-pushed
the
submit_storage_profile_id
branch
from
8f96ca0
to
0300fe7
Compare
ddneilson
commented
Sep 10, 2024
leongdl
previously approved these changes
Sep 10, 2024
ddneilson
force-pushed
the
submit_storage_profile_id
branch
from
0300fe7
to
ab41854
Compare
epmog
reviewed
Sep 10, 2024
ddneilson
force-pushed
the
submit_storage_profile_id
branch
from
ab41854
to
f9d97bb
Compare
leongdl
previously approved these changes
Sep 10, 2024
epmog
reviewed
Sep 10, 2024
Problem: Customers have expressed the need to be able to provide an override for the storage profile id when submitting jobs using `deadline bundle submit`, but that command doesn't provide a way to override that setting. The use-case is submitting many jobs, in parallel, from the same host where jobs need different storage profile ids. Solution: Add an override. Using the override does not store the given storage profile id to the user's configuration file. Signed-off-by: Daniel Neilson <[email protected]>
ddneilson
force-pushed
the
submit_storage_profile_id
branch
from
112f85e
to
bd4ace6
Compare
|
leongdl
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: No github issue created.
What was the problem/requirement? (What/Why)
Customers have expressed the need to be able to provide an override for the storage profile id when submitting jobs using
deadline bundle submit, but that command doesn't provide a way to override that setting. The use-case is submitting many jobs, in parallel, from the same host where jobs need different storage profile ids.What was the solution? (How)
Add an override. Using the override does not store the given storage profile id to the user's configuration file.
What is the impact of this change?
Those creating pipeline automation have one less barrier in their way.
How was this change tested?
I've run added to and run the unit tests. I have also run the new command option to ensure that the command submits jobs with the default as well as overriden storage profile id, and that the overriden id is not saved to the config. Log below:
Was this change documented?
The new CLI option does have help text that indicates what it is.
Is this a breaking change?
No. The change is purely additive, and 100% optional.
Does this change impact security?
It does not.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.