Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds --storage-profile-id option to the bundle submit command #442

Merged

Conversation

ddneilson
Copy link
Contributor

Fixes: No github issue created.

What was the problem/requirement? (What/Why)

Customers have expressed the need to be able to provide an override for the storage profile id when submitting jobs using deadline bundle submit, but that command doesn't provide a way to override that setting. The use-case is submitting many jobs, in parallel, from the same host where jobs need different storage profile ids.

What was the solution? (How)

Add an override. Using the override does not store the given storage profile id to the user's configuration file.

What is the impact of this change?

Those creating pipeline automation have one less barrier in their way.

How was this change tested?

I've run added to and run the unit tests. I have also run the new command option to ensure that the command submits jobs with the default as well as overriden storage profile id, and that the overriden id is not saved to the config. Log below:

% deadline config get settings.storage_profile_id                                    
sp-44e420f6a725493ba4067a89c60ce01c

% deadline bundle submit test_bundle
Submitting to Queue: MainQueue
Waiting for Job to be created...
Submitted job bundle:
   test_bundle
Job creation completed successfully
job-61473d1df8ba42ada64a74966171d644

% deadline job get
jobId: job-61473d1df8ba42ada64a74966171d644
...
storageProfileId: sp-44e420f6a725493ba4067a89c60ce01c
...     

% deadline config get settings.storage_profile_id                                    
sp-44e420f6a725493ba4067a89c60ce01c

% deadline bundle submit test_bundle --storage-profile-id sp-ef65fd46b42e46f19e4bb28dd2da7537
Submitting to Queue: MainQueue
Waiting for Job to be created...
Submitted job bundle:
   test_bundle
Job creation completed successfully
job-d711a6c9b1734e8f8bb826f7dffe1ea4

% deadline config get settings.storage_profile_id                                            
sp-44e420f6a725493ba4067a89c60ce01c

Was this change documented?

The new CLI option does have help text that indicates what it is.

Is this a breaking change?

No. The change is purely additive, and 100% optional.

Does this change impact security?

It does not.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ddneilson ddneilson force-pushed the submit_storage_profile_id branch 3 times, most recently from aec257a to 8f96ca0 Compare September 6, 2024 21:42
@ddneilson ddneilson marked this pull request as ready for review September 6, 2024 21:47
@ddneilson ddneilson requested a review from a team as a code owner September 6, 2024 21:47
leongdl
leongdl previously approved these changes Sep 6, 2024
leongdl
leongdl previously approved these changes Sep 10, 2024
leongdl
leongdl previously approved these changes Sep 10, 2024
test/unit/conftest.py Outdated Show resolved Hide resolved
Problem:

Customers have expressed the need to be able to provide an override for
the storage profile id when submitting jobs using `deadline bundle submit`,
but that command doesn't provide a way to override that setting. The use-case
is submitting many jobs, in parallel, from the same host where jobs need
different storage profile ids.

Solution:

Add an override. Using the override does not store the given storage profile
id to the user's configuration file.

Signed-off-by: Daniel Neilson <[email protected]>
Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Contributor

@epmog epmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! Ship it!

@ddneilson ddneilson merged commit 8c105ed into aws-deadline:mainline Sep 10, 2024
18 checks passed
@ddneilson ddneilson deleted the submit_storage_profile_id branch September 10, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants