fix: prevent redundant AWSAFTService Service Catalog Portfolio associations
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregCKrause
changed the title
AWSAFTService Service Catalog Portfolio assignmentsAWSAFTService Service Catalog Portfolio associations
|
@GregCKrause - I'm not affiliated with the AFT team, but what are your thoughts on putting the service catalog logic within the conditional branch of code where we already have an SQS message? I don't think we'd need to check service catalog unless there's actually an account request in the queue. |
|
Thanks for the pull request! We’re not accepting contributions at this time, but we’ll add this to our feature request backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485