first release #43

maiconrocha · 2023-05-09T12:33:26Z

No description provided.

aws-ia-automator-gamma · 2023-05-09T12:33:34Z

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.
If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are
not ready to publish yet, we recommend you close this PR and develop against a different branch.
Once you are ready to publish you can open a PR from that branch to main.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS PoC who is assisting you with this project.

maiconrocha · 2023-05-11T06:11:52Z

functional tests are running fine now

TestExamplesBasic 2023-05-11T06:03:34Z logger.go:66: Destroy complete! Resources: 52 destroyed.
TestExamplesBasic 2023-05-11T06:03:34Z logger.go:66: 
PASS
ok      github.com/aws-ia/terraform-project-ephemeral   2349.661s
End of Functional Tests
===========================================================================
TASK LOGS END
===========================================================================
[15:39](https://amzn-aws.slack.com/archives/D054UP6MBGV/p1683785391545639)

static-test as well

No problems detected!

Starting markdown lint
Success - markdown lint found no linting issues!
Starting terraform-docs
Success - Terraform Docs creation verified!
End of Static Tests
===========================================================================
TASK LOGS END
===========================================================================

maiconrocha · 2023-05-11T06:12:07Z

/confirm-publication

aws-ia-automator-gamma

Review hs been requested from required contributors, once they have approved I will remove my request for changes. When this PR is merged your project will be published

tbulding · 2023-05-11T19:56:18Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-05-11T19:56:26Z

Checks must all be completed successfully before end to end testing can be run.

tlindsay42 · 2023-05-11T22:06:21Z

Per our DMs, the error in static analysis is valid. It's because resource "aws_iam_role_policy_attachment" "custom_policy" is not conditionally created, but the variable is implemented as optional with a default of "", which that resource correctly won't accept for the policy_arn property. To fix it, make that resource conditional on var.custom_policy_arn having a value, or better yet, a length greater than 20 to match the rule, or even better than that- add the resource condition and a regex validation on the variable to ensure that it's either a properly formatted ARN or empty (default).

main.tf

maiconrocha · 2023-05-12T05:27:18Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-05-12T05:27:26Z

End to end test has been scheduled

aws-ia-automator-gamma · 2023-05-12T05:31:16Z

e2e test in progress

aws-ia-automator-gamma

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

maiconrocha · 2023-05-12T05:40:29Z

@tlindsay42 how I can check the logs for the e2e tests?

maiconrocha · 2023-05-28T00:41:58Z

/do-e2e-tests

maiconrocha · 2023-05-29T10:51:59Z

can someone please run the e2e tests again? I believe I have fixed the issue, local tests are ok.

aws-ia-automator-gamma · 2023-06-04T01:07:43Z

Checks must all be completed successfully before end to end testing can be run.

maiconrocha · 2023-06-04T08:56:37Z

static tests are failing now, weird
Failure - Terraform Docs creation failed, ensure you have precommit installed and running before submitting the Pull Request
it was working previously

maiconrocha · 2023-06-04T10:36:17Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-06-04T10:36:24Z

End to end test has been scheduled

aws-ia-automator-gamma · 2023-06-04T10:37:00Z

e2e test in progress

aws-ia-automator-gamma

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

maiconrocha · 2023-06-04T12:26:49Z

/do-e2e-tests

maiconrocha · 2023-06-04T12:29:44Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-06-04T12:29:50Z

End to end test has been scheduled

aws-ia-automator-gamma · 2023-06-04T12:30:17Z

e2e test in progress

aws-ia-automator-gamma

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

maiconrocha · 2023-06-05T03:22:35Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-06-05T03:22:42Z

Checks must all be completed successfully before end to end testing can be run.

maiconrocha · 2023-06-05T03:25:39Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-06-05T03:25:45Z

End to end test has been scheduled

aws-ia-automator-gamma · 2023-06-05T03:26:16Z

e2e test in progress

aws-ia-automator-gamma

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

maiconrocha · 2023-06-05T03:55:08Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-06-05T03:55:15Z

Checks must all be completed successfully before end to end testing can be run.

maiconrocha · 2023-06-05T03:56:24Z

/do-e2e-tests

aws-ia-automator-gamma · 2023-06-05T03:56:30Z

End to end test has been scheduled

aws-ia-automator-gamma · 2023-06-05T03:57:20Z

e2e test in progress

aws-ia-automator-gamma

e2e tests completed successfully

maiconrocha added 2 commits May 9, 2023 17:58

first release

98e8a9d

first release

c351dea

maiconrocha added 3 commits May 9, 2023 22:23

first release

31881c2

first release

ff2e2f2

first release

f98e030

maiconrocha changed the title ~~[Draft] first release~~ first release May 11, 2023

aws-ia-automator-gamma bot requested changes May 11, 2023

View reviewed changes

tbulding marked this pull request as draft May 11, 2023 20:30

tbulding marked this pull request as ready for review May 11, 2023 20:30

tbulding and others added 2 commits May 11, 2023 15:35

Update variables.tf

7ee019d

Updating linting rules version

d138874

tlindsay42 reviewed May 11, 2023

View reviewed changes

main.tf Show resolved Hide resolved

tbulding and others added 2 commits May 11, 2023 17:48

Adding tfvars configuration

b9f6b7e

first release

5892cb7

aws-ia-automator-gamma bot requested changes May 12, 2023

View reviewed changes

fix error with count

3ed8b2f

conditionally attach custom policy

b83fc90

maiconrocha requested a review from tlindsay42 May 29, 2023 10:51

update README

6a4495f

aws-ia-automator-gamma bot requested changes Jun 4, 2023

View reviewed changes

add variables for image recipe block devide mapping

c6cdf51

aws-ia-automator-gamma bot requested changes Jun 4, 2023

View reviewed changes

rename example

1a9ce56

aws-ia-automator-gamma bot requested changes Jun 5, 2023

View reviewed changes

rename instance profile

e413d68

aws-ia-automator-gamma bot approved these changes Jun 5, 2023

View reviewed changes

tbulding self-requested a review June 5, 2023 14:18

tbulding approved these changes Jun 5, 2023

View reviewed changes

tbulding merged commit a57771d into aws-ia:main Jun 5, 2023

first release #43

first release #43

Conversation

maiconrocha commented May 9, 2023

aws-ia-automator-gamma bot commented May 9, 2023

maiconrocha commented May 11, 2023

maiconrocha commented May 11, 2023

aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

tbulding commented May 11, 2023

aws-ia-automator-gamma bot commented May 11, 2023

tlindsay42 commented May 11, 2023

maiconrocha commented May 12, 2023

aws-ia-automator-gamma bot commented May 12, 2023

aws-ia-automator-gamma bot commented May 12, 2023

aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

maiconrocha commented May 12, 2023

maiconrocha commented May 28, 2023

maiconrocha commented May 29, 2023

aws-ia-automator-gamma bot commented Jun 4, 2023

maiconrocha commented Jun 4, 2023

maiconrocha commented Jun 4, 2023

aws-ia-automator-gamma bot commented Jun 4, 2023

aws-ia-automator-gamma bot commented Jun 4, 2023

aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

maiconrocha commented Jun 4, 2023

maiconrocha commented Jun 4, 2023

aws-ia-automator-gamma bot commented Jun 4, 2023

aws-ia-automator-gamma bot commented Jun 4, 2023

aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

maiconrocha commented Jun 5, 2023

aws-ia-automator-gamma bot commented Jun 5, 2023

maiconrocha commented Jun 5, 2023

aws-ia-automator-gamma bot commented Jun 5, 2023

aws-ia-automator-gamma bot commented Jun 5, 2023

aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

maiconrocha commented Jun 5, 2023

aws-ia-automator-gamma bot commented Jun 5, 2023

maiconrocha commented Jun 5, 2023

aws-ia-automator-gamma bot commented Jun 5, 2023

aws-ia-automator-gamma bot commented Jun 5, 2023

aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment