Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local irsa module to create k8s service account resources #1652

Closed
wants to merge 1 commit into from

Conversation

MohammadAlavi1986
Copy link

Description

Unlike the local ../../modules/irsa module, the terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks module does not create Kubernetes service account resources. Since no service accounts are being created, ExternalSecret resources will be created with an InvalidProviderConfig status.

Motivation and Context

  • Resolves #

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@MohammadAlavi1986 MohammadAlavi1986 requested a review from a team as a code owner June 16, 2023 20:36
@MohammadAlavi1986 MohammadAlavi1986 changed the title use local irsa module to create k8s service account resources fix: use local irsa module to create k8s service account resources Jun 16, 2023
@bryantbiggs
Copy link
Contributor

Thank you for the PR but we are moving off of the local modules. If you are encountering an issue, please start with a GitHub issue first so we can properly discuss and triage before moving to make any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants