feat: Adding a pattern for AWS for FluentBit with ContainerInsights and Kubelet monitoring integration. #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigobersa
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
rodrigobersa
changed the title
rodrigobersa
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
bryantbiggs
reviewed
Sep 20, 2023
| tags = local.tags | ||
| } | ||
|
|
||
| resource "aws_vpc_endpoint" "guardduty" { |
There was a problem hiding this comment.
copy+paste error? do we need these guardduty resource?
There was a problem hiding this comment.
No, I wanted to add GuardDuty. We don't really need it, however since we are showing a
"monitoring" pattern, I think it's interesting to add.
bryantbiggs
reviewed
Sep 20, 2023
| @@ -0,0 +1,337 @@ | |||
| # AWS for FluentBit with ContainerInsights and Kubelet monitoring. | |||
There was a problem hiding this comment.
I'll offer an alternative thought - what about showing this as a snippet?
- Most of the detail is in the README (and its great info), very little has to do with the Terraform
- I suspect there are a number of different logging configurations/scenarios that users may inquire about
- There isn't anything specific to the cluster itself
What do you think?
There was a problem hiding this comment.
You mean the whole main.tf as a snippet?
- Agreed, in fact nothing is related to Terraform, the init/plan/apply are provided by the link on the Deploy section.
- Yes, there are but not sure what is really useful or adopted by customers
- Nope!
What's your goal?
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Due the requests of features related to AWS for Fluentbit, and the lack of an existing examples for that, I'm adding this pattern to address those.
How was this change tested?
pre-commit run -awith this PRAdditional Notes