Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the first example of ArgoCD GitOps Bridge using v5 addon modules #1776

Merged
merged 44 commits into from
Nov 2, 2023

Conversation

csantanapr
Copy link
Contributor

@csantanapr csantanapr commented Sep 27, 2023

Description

Adds the first example of the new GitOps Bridge using v5 addon modules.

More examples to be moved and updated are located here

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@csantanapr csantanapr changed the title first example of ArgoCD GitOps Bridge using v5 addon modules [feat] Adds the first example of ArgoCD GitOps Bridge using v5 addon modules Sep 27, 2023
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
@csantanapr csantanapr changed the title [feat] Adds the first example of ArgoCD GitOps Bridge using v5 addon modules feat: Adds the first example of ArgoCD GitOps Bridge using v5 addon modules Oct 28, 2023
@csantanapr csantanapr marked this pull request as ready for review October 28, 2023 02:38
@csantanapr csantanapr requested a review from a team as a code owner October 28, 2023 02:38
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
@csantanapr
Copy link
Contributor Author

csantanapr commented Oct 30, 2023

This PR is ready for review

Anyone that wants to test it in ready only mode set these 2 variables

export TF_VAR_gitops_workload_org=https://github.com/csantanapr
export TF_VAR_gitops_workload_revision=gitops-bridge-1st-example

Deploy the cluster

terraform init
terraform apply -auto-approve

Continue with the instructions to kubectl apply the addons and workloads
https://github.com/csantanapr/terraform-aws-eks-blueprints/blob/gitops-bridge-1st-example/patterns/gitops/getting-started-argocd/README.md#deploy-the-eks-cluster

cc @rodrigobersa

Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
@csantanapr
Copy link
Contributor Author

@rodrigobersa thank you for the feedback, I made the changes based on your verbal feedback

Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only.

patterns/gitops/getting-started-argocd/README.md Outdated Show resolved Hide resolved
patterns/gitops/getting-started-argocd/README.md Outdated Show resolved Hide resolved
patterns/gitops/getting-started-argocd/README.md Outdated Show resolved Hide resolved
patterns/gitops/getting-started-argocd/README.md Outdated Show resolved Hide resolved
patterns/gitops/getting-started-argocd/README.md Outdated Show resolved Hide resolved
.github/workflows/e2e-parallel-destroy.yml Show resolved Hide resolved
.github/workflows/e2e-parallel-full.yml Show resolved Hide resolved
.github/workflows/e2e-parallel-full.yml Show resolved Hide resolved
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one I believe.

patterns/gitops/getting-started-argocd/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@rodrigobersa rodrigobersa merged commit d6d8c4f into aws-ia:main Nov 2, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GitOps] Add example of ArgoCD with v5 format
2 participants