Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions/upload-artifact from 3 to 4 #2576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump actions/upload-artifact from 3 to 4 #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:

# upload the binaries to artifact as well because cache@v3 hasn't support windows
- name: Upload
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binary_artifacts
path: build
Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:
}
Write-Output "Valid signature found from the package"
- name: Upload the msi
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: msi_artifacts
path: "${{ env.PACKAGING_ROOT }}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/PR-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ jobs:
# upload the binaries to artifact as well because cache@v2 hasn't support windows
- name: Upload
if: ${{ needs.changes.outputs.changed == 'true' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binary_artifacts
path: build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ jobs:
cd testing-framework/terraform/performance && terraform init && terraform apply -auto-approve -lock=false -var="data_rate=${{ matrix.data_rate }}" -var="commit_id=${{ needs.get-testing-version.outputs.commit_id }}" $opts -var="aoc_version=${{ needs.get-testing-version.outputs.testing_version }}" -var="testcase=../testcases/${{ matrix.testcase }}" -var="testing_ami=${{ matrix.testing_ami }}" -var="ssh_key_name=aoc-ssh-key-2022-09-13" -var="sshkey_s3_bucket=aoc-ssh-key" -var="sshkey_s3_private_key=aoc-ssh-key-2022-09-13.txt"

- name: Upload the performance model as an artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "performance-model-${{ matrix.testcase }}-${{ matrix.data_rate }}-${{ matrix.testing_ami }}"
path: testing-framework/terraform/performance/output/performance.json
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rollback.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
fi
done
- name: Upload versions artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.type }}-versions
path: ${{ env.SSM_ARTIFACT_ROOT }}
Expand Down
Loading