fix: keep alive when dispatch fails with 401 #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williazz
changed the title
ps863
reviewed
May 7, 2024
| @@ -479,36 +479,6 @@ describe('Dispatch tests', () => { | |||
| expect((dispatch as unknown as any).enabled).toBe(true); | |||
| }); | |||
|
|
|||
| test('when a fetch request is rejected with 401 then dispatch is disabled', async () => { | |||
There was a problem hiding this comment.
nit: do we need reverse of this unit test?
There was a problem hiding this comment.
It's not scalable for every status code to have a separate unit test. In the future, we should consolidate them into either "keep alive" or "disable".
ps863
approved these changes
May 7, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dispatch fails with 401, then RUM should keep alive.
RUM backend does not respond with 401 so this is change is not relevant for standard setups. However, some users have setup proxy servers with valid use cases.
For example #524 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.