-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): Adding thread safe logging keys #5141
base: v2
Are you sure you want to change the base?
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Assigned to @sthulb. |
7fc9e57
to
22956ce
Compare
Quality Gate passedIssues Measures |
@sthulb I have made some changes to my PR since the last batch of tests failed due to type checking and |
@SimonBFrank We have paused all development and merging in to develop/v3 branches until v3 has gone GA, which is currently scheduled for the 23rd now. We will review and merge after that. Thank you for this contribution. |
Issue number: RFC: Support thread-local keys for logger #991
Summary
Changes
append_thread_local_keys
: add key to thread-local ContextVarget_current_thread_keys
: get all keys from thread-local ContextVarremove_thread_local_keys
: remove list of keys from thread-local ContextVarclear_thread_local_keys
: remove all keys from thread-local ContextVar_extract_log_keys
method to handle error when an additional logging key's value is not a string and the name conflicts with a reserved keysclear_state
ininject_lambda_context
also clears thread-local keysUser experience
Before:
After:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?: No, existing functionality isn't broken.
RFC issue number:Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.