Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(idempotency): fix description in Advanced table #5191

Merged
merged 3 commits into from
Sep 25, 2024
Merged

docs(idempotency): fix description in Advanced table #5191

merged 3 commits into from
Sep 25, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Sep 20, 2024 •
edited by leandrodamascena
Loading

Issue number: #5193

Summary

Changes

  • Improved the description for payload_validation_jmespath to make it more clear

Issue: #5193

Related TS Issue: aws-powertools/powertools-lambda-typescript#3098
Related TS PR: aws-powertools/powertools-lambda-typescript#3092

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@garysassano garysassano requested a review from a team as a code owner September 20, 2024 01:58
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 20, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 20, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Sep 20, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2024
@garysassano garysassano mentioned this pull request Sep 20, 2024
Merged
@leandrodamascena leandrodamascena changed the base branch from v2 to develop September 23, 2024 11:27
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Sep 23, 2024
@sthulb sthulb changed the base branch from develop to v2 September 23, 2024 11:43
@sthulb sthulb changed the base branch from v2 to develop September 23, 2024 11:43
@leandrodamascena leandrodamascena changed the base branch from develop to v2 September 23, 2024 21:35
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Sep 23, 2024
@leandrodamascena leandrodamascena changed the base branch from v2 to develop September 23, 2024 21:40
@leandrodamascena
Copy link
Contributor

Hi @garysassano! Thank you very much for submitting this PR! We made some changes to our branches because we had to release V3 and this PR became impossible to merge due to too many conflicts.

Do you mind closing this PR and opening another one against develop? You may need to pull the repository/branches again because we changed a lot.

@garysassano
Copy link
Contributor Author

@leandrodamascena I updated my branch.

@leandrodamascena
Copy link
Contributor

Thanks a lot @garysassano! I'm approving this PR and will wait for @dreamorosi to merge it into TS before merging it here. Since you're working there, I'll wait to see if there are any other changes.

leandrodamascena
leandrodamascena approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi
Copy link
Contributor

I just merged the the corresponding PR on the TS repo, feel free to merge this whenever you want.

@dreamorosi dreamorosi removed dependencies Pull requests that update a dependency file do-not-merge github-actions Pull requests that update Github_actions code labels Sep 25, 2024
@leandrodamascena leandrodamascena linked an issue Sep 25, 2024 that may be closed by this pull request
Docs: Improve parameter descriptions in Idempotency Advanced table #5193
Closed
1 task
@leandrodamascena leandrodamascena merged commit 4d261b7 into aws-powertools:develop Sep 25, 2024
7 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Sep 25, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees

@garysassano garysassano

Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Improve parameter descriptions in Idempotency Advanced table
3 participants
@garysassano @leandrodamascena @dreamorosi